Make Slider UI elements larger when widget size increases#3855
Open
georgweiss wants to merge 2 commits into
Open
Make Slider UI elements larger when widget size increases#3855georgweiss wants to merge 2 commits into
georgweiss wants to merge 2 commits into
Conversation
jacomago
reviewed
Jul 2, 2026
| */ | ||
| private void adjustSizes(){ | ||
| SliderSkin skin = (SliderSkin) slider.getSkin(); | ||
| if (skin != null) { |
Contributor
There was a problem hiding this comment.
If you return for skin == null you avoid the heavy nesting.
Collaborator
Author
There was a problem hiding this comment.
"Heavy" is maybe not how I would describe it, but I'll update.
| for (Node node : skin.getChildren()) { | ||
| if (node.getStyleClass().contains("thumb")) { | ||
| // 7.6 seems to be default padding | ||
| node.setStyle("-fx-padding: " + Math.clamp(size * 0.3, 7.6, 20)); |
Contributor
There was a problem hiding this comment.
Can you define all these numbers as constants with descriptive names?
Then you don't really need the comments
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #3854 to deal with code formatting and readability.
Testing:
Documentation: